Fix case of various components #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were places in the code where code was duplicated or could return different results based on the locale. Duplicate code was moved to new methods. The locale-specic lowercase method were replaced by an ASCII-specific lowecase method.
This was referenced Feb 28, 2025
jeremylong
requested changes
Mar 9, 2025
jeremylong
reviewed
Mar 9, 2025
jeremylong
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were places in the code where code was duplicated or could return different results based on the locale. Duplicate code was moved to new methods. The locale-specic lowercase method were replaced by an ASCII-specific lowecase method.